Expose TryGetDateTimeInput to be usable by custom filters#431
Merged
sebastienros merged 3 commits intosebastienros:mainfrom Jan 2, 2022
Merged
Expose TryGetDateTimeInput to be usable by custom filters#431sebastienros merged 3 commits intosebastienros:mainfrom
sebastienros merged 3 commits intosebastienros:mainfrom
Conversation
…an extension method.
Collaborator
|
I agree, it will be much cleaner if we move it to |
…ss along with the private static values it depends on.
Contributor
Author
|
I created an Extensions folder in the Fluid project and tried adding a FluidValueExtensions class with the Fluid.Values namespace, but it was conflicting with an existing FluidValueExtensions class in the Values folder. I decided to move it into the existing FluidValueExtensions class. Does this work for you, or would you prefer both the new and existing extension be moved into a new Extensions folder? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a few custom filters in my solution for manipulating DateTime values and this would have been much easier if the TryGetDateTimeInput was made public or exposed.
I noticed there was another extension in this file and thought this would be a clean and simple approach that exposes this for custom filters in the Fluid.Filters namespace.